Graphql, Web: Add remotes tab, list, add, and delete remotes #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuliu-dev
changed the title
Graphql, Web: Add and delete remote
liuliu-dev
changed the title
tbantle22
approved these changes
Dec 3, 2024
Comment on lines
10
to
11
| export type AddRemoteArgs = DBArgs & { remoteName: string; remoteUrl: string }; | ||
| export type RemoteArgs = DBArgs & { remoteName: string }; |
There was a problem hiding this comment.
Suggested change
| export type AddRemoteArgs = DBArgs & { remoteName: string; remoteUrl: string }; | |
| export type RemoteArgs = DBArgs & { remoteName: string }; | |
| export type RemoteArgs = DBArgs & { remoteName: string }; | |
| export type AddRemoteArgs = RemoteArgs & { remoteUrl: string }; |
| } | ||
| } | ||
|
|
||
| function getRemoteListRes( |
There was a problem hiding this comment.
This probably belongs in model
| loading, | ||
| } = useMutation({ | ||
| hook: useAddRemoteMutation, | ||
| refetchQueries: refetchBranchQueries(props.params), |
There was a problem hiding this comment.
Should this be refetchRemoteQueries?
| }; | ||
|
|
||
| const DatabaseRemotesPage: NextPage<Props> = ({ params }) => ( | ||
| <Page title={`Add remote for ${params.databaseName}`} noIndex> |
There was a problem hiding this comment.
Suggested change
| <Page title={`Add remote for ${params.databaseName}`} noIndex> | |
| <Page title={`New remote for ${params.databaseName}`} noIndex> |
| params: DatabaseParams; | ||
| }; | ||
|
|
||
| const DatabaseRemotesPage: NextPage<Props> = ({ params }) => ( |
There was a problem hiding this comment.
Suggested change
| const DatabaseRemotesPage: NextPage<Props> = ({ params }) => ( | |
| const DatabaseNewRemotePage: NextPage<Props> = ({ params }) => ( |
|
|
||
| export default function ForRemotes({ params, newRemote }: Props): JSX.Element { | ||
| const feature = newRemote ? "Creating remotes" : "Viewing Remotes"; | ||
| console.log("ForRemotes", params, newRemote); |
| }; | ||
|
|
||
| export default function ForRemotes({ params, newRemote }: Props): JSX.Element { | ||
| const feature = newRemote ? "Creating remotes" : "Viewing Remotes"; |
There was a problem hiding this comment.
Suggested change
| const feature = newRemote ? "Creating remotes" : "Viewing Remotes"; | |
| const feature = newRemote ? "Creating remotes" : "Viewing remotes"; |
Comment on lines
20
to
25
| {remote.fetchSpecs?.map((fs, i) => ( | ||
| <span key={fs}> | ||
| {fs} | ||
| {i < (remote.fetchSpecs?.length ?? 0) - 1 ? ", " : ""} | ||
| </span> | ||
| ))} |
There was a problem hiding this comment.
Can you just remote.fetchSpecs?.join(",") here? Does the span apply any styling?
| const [offset, setOffset] = useState(data?.remotes.nextOffset); | ||
| const [lastOffset, setLastOffset] = useState<Maybe<number>>(undefined); | ||
|
|
||
| const refetch = async () => { |
tbantle22
approved these changes
Dec 4, 2024
Comment on lines
146
to
149
| let sel = em.createQueryBuilder().select("*").from("dolt_remotes", ""); | ||
| sel = sel.offset(args.offset); | ||
|
|
||
| return sel.limit(ROW_LIMIT + 1).getRawMany(); |
There was a problem hiding this comment.
Do you need the let here? It can all just be chained together?
| ) | ||
| } | ||
| `; | ||
|
|
||
| export const DELETE_REMOTE = gql` |
There was a problem hiding this comment.
These should go in RemotesPage too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.